fureunoir/schon
fureunoir/schon
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Refactor attribute retrieval logic in detail serializer.

Browse source 
Simplify the conditional logic for fetching attributes based on user permissions. This improves code readability and maintains the same functionality.
This commit is contained in:
Egor Pavlovich Gorbunov 2025-05-07 04:40:44 +03:00
parent 6c04faf97b
commit 4d63bde7a3
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
core/serializers/detail.py
View file

@ -78,10 +78,7 @@ class CategoryDetailSerializer(ModelSerializer):
request = self.context.get("request")
user = getattr(request, "user", None)
if user is not None and user.has_perm("view_attribute"):
attributes = obj.attributes.all()
else:
attributes = obj.attributes.filter(is_active=True)
attributes = obj.attributes.all() if user.has_perm("view_attribute") else obj.attributes.filter(is_active=True)
for attr in attributes:
distinct_vals = (