From 4d63bde7a3e05c2f1512a9cf2f6c400d1c15f51d Mon Sep 17 00:00:00 2001 From: Egor fureunoir Gorbunov Date: Wed, 7 May 2025 04:40:44 +0300 Subject: [PATCH] Refactor attribute retrieval logic in detail serializer. Simplify the conditional logic for fetching attributes based on user permissions. This improves code readability and maintains the same functionality. --- core/serializers/detail.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/core/serializers/detail.py b/core/serializers/detail.py index bc2d471e..058d17f7 100644 --- a/core/serializers/detail.py +++ b/core/serializers/detail.py @@ -78,10 +78,7 @@ class CategoryDetailSerializer(ModelSerializer): request = self.context.get("request") user = getattr(request, "user", None) - if user is not None and user.has_perm("view_attribute"): - attributes = obj.attributes.all() - else: - attributes = obj.attributes.filter(is_active=True) + attributes = obj.attributes.all() if user.has_perm("view_attribute") else obj.attributes.filter(is_active=True) for attr in attributes: distinct_vals = (