From eb59f9c96eaef1ec87ceeeb7a14aa7df7cd5e0ed Mon Sep 17 00:00:00 2001 From: Egor fureunoir Gorbunov Date: Fri, 30 May 2025 17:35:12 +0300 Subject: [PATCH] Features: 1) Add "name" to filter_fields in BrandType. Fixes: 1) Simplify resolve_children method in CategoryType by removing unused depth argument. Extra: 1) Remove redundant depth parameter declaration; 2) General code cleanup in CategoryType. --- core/graphene/object_types.py | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/core/graphene/object_types.py b/core/graphene/object_types.py index 2465ce0a..dcaff0fb 100644 --- a/core/graphene/object_types.py +++ b/core/graphene/object_types.py @@ -79,7 +79,7 @@ class BrandType(DjangoObjectType): model = Brand interfaces = (relay.Node,) fields = ("uuid", "categories", "name") - filter_fields = ["uuid"] + filter_fields = ["uuid", "name"] description = _("brands") def resolve_categories(self, info): @@ -101,7 +101,6 @@ class MinMaxPriceType(ObjectType): class CategoryType(DjangoObjectType): children = List( lambda: CategoryType, - depth=Int(default_value=None), description=_("categories"), ) image = String(description=_("category image url")) @@ -132,15 +131,7 @@ class CategoryType(DjangoObjectType): filter_fields = ["uuid"] description = _("categories") - def resolve_children(self, info, depth=None) -> TreeQuerySet: - max_depth = self.get_tree_depth() - - if depth is None: - depth = max_depth - - if depth <= 0: - return Category.objects.none() - + def resolve_children(self, info) -> TreeQuerySet: categories = Category.objects.filter(parent=self) if info.context.user.has_perm("core.view_category"): return categories