fureunoir/schon
fureunoir/schon
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Features: 1) Remove unused small_logo and big_logo fields from BrandProductDetailSerializer and BrandSimpleSerializer.

Browse source 
Fixes: 1) None.

Extra: 1) Cleanup unused methods and associated meta field definitions for logo handling in serializers.
This commit is contained in:
Egor Pavlovich Gorbunov 2025-11-11 16:00:42 +03:00
parent 5f9f07d8f4
commit a2665b593b
2 changed files with 0 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
engine/core/serializers/detail.py
View file

@ -117,8 +117,6 @@ class BrandDetailSerializer(ModelSerializer):
class BrandProductDetailSerializer(ModelSerializer): class BrandProductDetailSerializer(ModelSerializer):
small_logo = SerializerMethodField()
big_logo = SerializerMethodField()
class Meta: class Meta:
model = Brand model = Brand
@ -131,16 +129,6 @@ class BrandProductDetailSerializer(ModelSerializer):
"small_logo", "small_logo",
] ]
def get_small_logo(self, obj: Brand) -> str | None:
with suppress(ValueError):
return obj.small_logo.url
return None
def get_big_logo(self, obj: Brand) -> str | None:
with suppress(ValueError):
return obj.big_logo.url
return None
class ProductTagDetailSerializer(ModelSerializer): class ProductTagDetailSerializer(ModelSerializer):
class Meta: class Meta:

12
engine/core/serializers/simple.py
View file

@ -64,8 +64,6 @@ class CategorySimpleSerializer(ModelSerializer): # type: ignore [type-arg]
class BrandSimpleSerializer(ModelSerializer): # type: ignore [type-arg] class BrandSimpleSerializer(ModelSerializer): # type: ignore [type-arg]
small_logo = SerializerMethodField()
big_logo = SerializerMethodField()
class Meta: class Meta:
model = Brand model = Brand
@ -76,16 +74,6 @@ class BrandSimpleSerializer(ModelSerializer): # type: ignore [type-arg]
"big_logo", "big_logo",
] ]
def get_small_logo(self, obj: Brand) -> str | None:
with suppress(ValueError):
return str(obj.small_logo.url)
return None
def get_big_logo(self, obj: Brand) -> str | None:
with suppress(ValueError):
return str(obj.big_logo.url)
return None
class ProductTagSimpleSerializer(ModelSerializer): # type: ignore [type-arg] class ProductTagSimpleSerializer(ModelSerializer): # type: ignore [type-arg]
class Meta: class Meta: