From 45ae5b02f3810fb785d6e5f22268f21fa755a80f Mon Sep 17 00:00:00 2001 From: Egor fureunoir Gorbunov Date: Wed, 12 Nov 2025 15:36:43 +0300 Subject: [PATCH] Features: (1) Adjust group creation logic to assign permissions only when groups are newly created; Fixes: (1) Correct conditional checks in group initialization to ensure permission assignment; Extra: (1) Minor refactor to improve code readability around permission assignment logic; --- engine/core/management/commands/initialize.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/engine/core/management/commands/initialize.py b/engine/core/management/commands/initialize.py index bbb3dd8f..84544b01 100644 --- a/engine/core/management/commands/initialize.py +++ b/engine/core/management/commands/initialize.py @@ -129,27 +129,27 @@ class Command(BaseCommand): Vendor.objects.get_or_create(name="INNER") user_support, is_user_support_created = Group.objects.get_or_create(name="User Support") - if not is_user_support_created: + if is_user_support_created: perms = Permission.objects.filter(codename__in=user_support_permissions) user_support.permissions.add(*perms) stock_manager, is_stock_manager_created = Group.objects.get_or_create(name="Stock Manager") - if not is_stock_manager_created: + if is_stock_manager_created: perms = Permission.objects.filter(codename__in=stock_manager_permissions) stock_manager.permissions.add(*perms) head_stock_manager, is_head_stock_manager_created = Group.objects.get_or_create(name="Head Stock Manager") - if not is_head_stock_manager_created: + if is_head_stock_manager_created: perms = Permission.objects.filter(codename__in=head_stock_manager_permissions) head_stock_manager.permissions.add(*perms) marketing_admin, is_marketing_admin_created = Group.objects.get_or_create(name="Marketing Admin") - if not is_marketing_admin_created: + if is_marketing_admin_created: perms = Permission.objects.filter(codename__in=marketing_admin_permissions) marketing_admin.permissions.add(*perms) e_commerce_admin, is_e_commerce_admin_created = Group.objects.get_or_create(name="E-Commerce Admin") - if not is_e_commerce_admin_created: + if is_e_commerce_admin_created: perms = Permission.objects.filter(codename__in=e_commerce_admin_permissions) e_commerce_admin.permissions.add(*perms)